fix(security): implement security audit fixes and architecture improvements #5

Merged

Jairodaniel-17 merged 2 commits from audit-fixes-11737152559706453928 into main

2026-05-29 21:34:32 +00:00

Jairodaniel-17 commented

2026-05-29 21:09:24 +00:00

(Migrated from github.com)

This commit addresses all P0 and P1 issues raised in the recent security audit report:

Security (P0)
- Replaced .env with .env.example to remove default exposed API keys.
- Refactored src/api/auth.rs to demand a configured API key, eliminating open access fallback by default. Used subtle::ConstantTimeEq to prevent timing attacks.
- Deleted highly insecure raw SQL endpoints (/v1/sql/exec and /v1/sql/query) and associated logic/tests.
Concurrency Improvement (P1)
- Mitigated the SQLite single actor bottleneck by implementing a Read/Write Connection Pool (SqliteReaderPool). Readers correctly leverage the existing WAL mode for high concurrency.
Data Integrity & Tech Debt (P0/P1)
- Addressed unbound memory scaling by migrating prepare_cached back to standard prepare in actors and pools.
- Enhanced rollback_ingest to log failures cleanly instead of silently ignoring failures during rollback actions.
- Reduced unwrap() calls on critical paths (src/engine/hub.rs, src/engine/embeddings.rs), improving system stability and preventing unhandled panics.
Repository Fixes
- Standardized LICENCE to LICENSE.
- Repatched release.yml CI definition to employ --locked logic preventing unrepeatable or supply-chain compromised release outputs.

PR created automatically by Jules for task 11737152559706453928 started by @Jairodaniel-17

This commit addresses all P0 and P1 issues raised in the recent security audit report: 1. **Security (P0)** - Replaced `.env` with `.env.example` to remove default exposed API keys. - Refactored `src/api/auth.rs` to demand a configured API key, eliminating open access fallback by default. Used `subtle::ConstantTimeEq` to prevent timing attacks. - Deleted highly insecure raw SQL endpoints (`/v1/sql/exec` and `/v1/sql/query`) and associated logic/tests. 2. **Concurrency Improvement (P1)** - Mitigated the SQLite single actor bottleneck by implementing a Read/Write Connection Pool (`SqliteReaderPool`). Readers correctly leverage the existing WAL mode for high concurrency. 3. **Data Integrity & Tech Debt (P0/P1)** - Addressed unbound memory scaling by migrating `prepare_cached` back to standard `prepare` in actors and pools. - Enhanced `rollback_ingest` to log failures cleanly instead of silently ignoring failures during rollback actions. - Reduced `unwrap()` calls on critical paths (`src/engine/hub.rs`, `src/engine/embeddings.rs`), improving system stability and preventing unhandled panics. 4. **Repository Fixes** - Standardized `LICENCE` to `LICENSE`. - Repatched `release.yml` CI definition to employ `--locked` logic preventing unrepeatable or supply-chain compromised release outputs. --- *PR created automatically by Jules for task [11737152559706453928](https://jules.google.com/task/11737152559706453928) started by @Jairodaniel-17*

google-labs-jules[bot] commented

2026-05-29 21:09:25 +00:00

(Migrated from github.com)

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to **Reactive Mode**. When this mode is on, I will only act on comments where you specifically mention me with `@jules`. You can find this option in the **Pull Request** section of your [global Jules UI settings](https://jules.google.com/settings). You can always switch back! New to Jules? Learn more at [jules.google/docs](https://jules.google/docs). --- *_For security, I will only act on instructions from the user who triggered this task._*